-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[CI] Experimental homebrew-based CI for mac VMs #20126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
hageboeck
wants to merge
15
commits into
root-project:master
Choose a base branch
from
hageboeck:experimental-brew-ci
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+117
−78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 3 files 3 suites 11h 11m 3s ⏱️ For more details on these failures, see this check. Results for commit 735a13a. ♻️ This comment has been updated with latest results. |
c46acc5 to
7d14b31
Compare
3a527fa to
6451040
Compare
This will allow for simplifying the CI, since build option overrides can be passed to build_root.py without text-file manipulations.
- Choose login shell for all MacOS steps. - Use homebrew and python-venv to install dependencies - Use github checkout action to get the code
Now that overrides can be passed as arguments to the configure script, no further modifications of text files are required.
e516e40 to
e819c0c
Compare
e819c0c to
88c668b
Compare
Homebrew doesn't natively provide it, so it seems easier to use a builtin.
844ffa6 to
a0688fa
Compare
4f49daf to
3ffc287
Compare
3ffc287 to
9769df0
Compare
d2531f8 to
092001c
Compare
092001c to
14e4088
Compare
build_root.py could be run locally without access to openstack if no uploads of build caches are attempted. Here, all openstack-related imports are moved to the function that actually does the upload, so the rest of the script can be run standalone.
df6e07b to
735a13a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description to follow